Changeset 2189

Timestamp:

12/24/03 00:13:38 (5 years ago)

Author:

mds

Message:

remove -o and -g args to install

Date: Thu, 18 Dec 2003 22:42:36 +0100
From: Haakon Riiser <haakon.riiser@fys.uio.no>
To: sensors@Stimpy.netroedge.com
Subject: lm_sensors 2.8.2 / DESTDIR / root

The reason for this email is that I always try to avoid running
Makefiles as root, even during 'make install'. Therefore, I
always use the DESTDIR feature, when it's available. Until today,
I always built i2c and lm_sensors by doing

$ make
$ make -i install DESTDIR=/foo
$ cd /foo && su root && fix permissions/ownership && install

The -i flag to make install is a kludge to avoid having to be root
while installing to the DESTDIR, and it's only required because
the files are installed with "-o root -g root". Using the -i
flag is of course not a good idea, since more fatal errors can
easily fly by undetected.

Today, I upgraded to Linux 2.6.0, and tried a similar install
procedure for lm_sensors, except that the make target is now "user"
and the install target is "user_install". I now noticed that the
DESTDIR variable is not used everywhere in "user_install", so I
couldn't use the -i kludge anymore. Instead, I wrote a patch that
removes the "-o root -g root" arguments to install everywhere, and
I also tried to add DESTDIR to all files/directories installed.
(The patch only applies to lm_sensors, not i2c, since only
lm_sensors is required in Linux 2.6.0.)

There's really no reason to say -o root -g root anyway, since if you
do install directly with make install, you have to be logged in as
root, and then the files will get the right ownership by default.
Much of the point of installing to a temporary DESTDIR is that you
don't have to be root, and that you can prepare the installation
by hand. Fixing the ownership is trivial:

chown -R root.root $DESTDIR

Files:

• lm-sensors/trunk/Makefile (modified) (1 diff)
• lm-sensors/trunk/etc/Module.mk (modified) (1 diff)
• lm-sensors/trunk/kernel/busses/Module.mk (modified) (1 diff)
• lm-sensors/trunk/kernel/chips/Module.mk (modified) (1 diff)
• lm-sensors/trunk/kernel/include/Module.mk (modified) (1 diff)
• lm-sensors/trunk/lib/Module.mk (modified) (2 diffs)
• lm-sensors/trunk/prog/detect/Module.mk (modified) (1 diff)
• lm-sensors/trunk/prog/dump/Module.mk (modified) (1 diff)
• lm-sensors/trunk/prog/eeprom/Module.mk (modified) (1 diff)
• lm-sensors/trunk/prog/pwm/Module.mk (modified) (1 diff)
• lm-sensors/trunk/prog/sensord/Module.mk (modified) (1 diff)
• lm-sensors/trunk/prog/sensors/Module.mk (modified) (1 diff)
• lm-sensors/trunk/prog/xeon/Module.mk (modified) (1 diff)

lm-sensors/trunk/Makefile

@@ -122 +122 @@
-MANDIR := $(PREFIX)/man
-
-# You should not need to change this. It defines the manual owner and group
-# as which manual pages are installed.
-MANOWN := root
-MANGRP := root
-
-MACHINE := $(shell uname -m)
-

lm-sensors/trunk/etc/Module.mk

@@ -30 +30 @@
-        $(MKDIR) $(DESTDIR)$(ETCDIR)
-        if [ ! -e $(DESTDIR)$(ETCINSTALL) ] ; then \
-o  root -g root -
+
-        fi
-user_install :: install-etc

lm-sensors/trunk/kernel/busses/Module.mk

@@ -106 +106 @@
-        if [ -n "$(KERNELBUSSESTARGETS)" ] ; then \
-          $(MKDIR) $(DESTDIR)$(MODPREF)/kernel/drivers/i2c/busses ; \
-o root -g root -
+
-          for i in $(KERNELBUSSESTARGETS) ; do \
-            $(RM) $(DESTDIR)$(MODPREF)/misc/`basename $$i` $(DESTDIR)$(MODPREF)/kernel/drivers/i2c/`basename $$i` \

lm-sensors/trunk/kernel/chips/Module.mk

@@ -161 +161 @@
-        if [ -n "$(KERNELCHIPSTARGETS)" ] ; then \
-          $(MKDIR) $(DESTDIR)$(MODPREF)/kernel/drivers/i2c/chips ; \
-o root -g root -
+
-          for i in $(KERNELCHIPSTARGETS) ; do \
-            $(RM) $(DESTDIR)$(MODPREF)/misc/`basename $$i` $(DESTDIR)$(MODPREF)/kernel/drivers/sensors/`basename $$i` \

lm-sensors/trunk/kernel/include/Module.mk

@@ -40 +40 @@
-        if [ -n "$(KERNELINCLUDEFILES)" ] ; then \
-          $(MKDIR) $(DESTDIR)$(SYSINCLUDEDIR) ; \
-o root -g root -
+
-        fi
-

lm-sensors/trunk/lib/Module.mk

@@ -111 +111 @@
-             echo '******************************************************************************' ; \
-        fi
-o root -g root -
+
-        $(LN) $(LIBSHLIBNAME) $(DESTDIR)$(LIBDIR)/$(LIBSHSONAME)
-        $(LN) $(LIBSHSONAME) $(DESTDIR)$(LIBDIR)/$(LIBSHBASENAME)
@@ -133 +133 @@
-                  echo '******************************************************************************' ) ; \
-        fi
-o root -g root -
-o $(MANOWN) -g $(MANGRP) -
-o $(MANOWN) -g $(MANGRP) -
+
+
+
-
-

lm-sensors/trunk/prog/detect/Module.mk

@@ -40 +40 @@
-
-install-prog-detect: all-prog-detect
-mkdir -p
-o root -g root -
+$(MKDIR)
+
-user_install :: install-prog-detect
-

lm-sensors/trunk/prog/dump/Module.mk

@@ -45 +45 @@
-
-install-prog-dump: all-prog-dump
-mkdir -p
-o root -g root -
+$(MKDIR)
+
-user_install :: install-prog-dump
-

lm-sensors/trunk/prog/eeprom/Module.mk

@@ -25 +25 @@
-install-prog-eeprom: $(PROGEEPROMTARGETS)
-        $(MKDIR) $(DESTDIR)$(BINDIR)
-o root -g root -
+
-
-user_install :: install-prog-eeprom

lm-sensors/trunk/prog/pwm/Module.mk

@@ -24 +24 @@
-install-prog-pwm: $(PROGPWMTARGETS)
-        $(MKDIR) $(DESTDIR)$(SBINDIR)
-o root -g root -
+
-
-user_install :: install-prog-pwm

lm-sensors/trunk/prog/sensord/Module.mk

@@ -46 +46 @@
-install-prog-sensord: all-prog-sensord
-        $(MKDIR) $(DESTDIR)$(SBINDIR) $(DESTDIR)$(PROGSENSORDMAN1DIR)
-o root -g root -
-o $(MANOWN) -g $(MANGRP) -
+
+
-user_install :: install-prog-sensord
-

lm-sensors/trunk/prog/sensors/Module.mk

@@ -41 +41 @@
-
-install-prog-sensors: all-prog-sensors
-mkdir -p
-o root -g root -
-o $(MANOWN) -g $(MANGRP) -
+$(MKDIR)
+
+
-user_install :: install-prog-sensors
-

lm-sensors/trunk/prog/xeon/Module.mk

@@ -23 +23 @@
-install-prog-xeon: $(PROGXEONTARGETS)
-        $(MKDIR) $(DESTDIR)$(BINDIR)
-o root -g root -
+
-
-user_install :: install-prog-xeon