Changeset 2692

Timestamp:

09/19/04 19:37:18 (9 years ago)

Author:

khali

Message:

Fix a bug in libsensors which caused some failed feature writes

("set lines") to go unnoticed. lm78's fan3_div (which is read-only
but stored in a R/W file in procfs) was one of them.
Make sensors' error message in this case more explicit.

Location:

lm-sensors/trunk

Files:

• lib/access.c (modified) (2 diffs)
• prog/sensors/main.c (modified) (1 diff)

lm-sensors/trunk/lib/access.c

@@ -426 +426 @@
   sensors_chip *chip;
   double value;
-  int err,i,j;
-  int res = 0;
+  int i, j;
+  int err = 0, res;
   const sensors_chip_feature *feature;
   int *feature_list = NULL;
@@ -465 +465 @@
     }
   free(feature_list);
-  return res;
+  return err;
 }
 

lm-sensors/trunk/prog/sensors/main.c

@@ -329 +329 @@
       fprintf(stderr,"Run as root?\n");
       return 1;
+    } else if (res == -SENSORS_ERR_ACCESS_W) {
+      fprintf(stderr, "%s: At least one \"set\" statement failed\n",
+              sprintf_chip_name(name));
     } else {
       fprintf(stderr,"%s: %s\n",sprintf_chip_name(name),