Changeset 4635 for lm-sensors/trunk/lib/sysfs.c

Timestamp:

07/21/07 10:40:26 (5 years ago)

Author:

khali

Message:

Fix a memory leak in sensors_read_one_sysfs_chip() when an error occurs.

Files:

• lm-sensors/trunk/lib/sysfs.c (modified) (3 diffs)

lm-sensors/trunk/lib/sysfs.c

@@ -22 +22 @@
 
 #include <string.h>
+#include <stdlib.h>
 #include <limits.h>
 #include <errno.h>
@@ -84 +85 @@
 
                         if ((bus_attr = sysfs_open_attribute(bus_path))) {
-                                if (sysfs_read_attribute(bus_attr))
-                                        return -SENSORS_ERR_PARSE;
+                                if (sysfs_read_attribute(bus_attr)) {
+                                        sysfs_close_attribute(bus_attr);
+                                        goto exit_free;
+                                }
 
                                 if (bus_attr->value
@@ -102 +105 @@
                 entry.name.bus = SENSORS_CHIP_NAME_BUS_PCI;
         } else
-                return -SENSORS_ERR_PARSE;
+                goto exit_free;
 
         sensors_add_proc_chips(&entry);
 
         return 0;
+
+exit_free:
+        free(entry.name.prefix);
+        free(entry.name.busname);
+        return -SENSORS_ERR_PARSE;
 }