Changeset 5544

Timestamp:

12/09/08 14:26:58 (3 years ago)

Author:

khali

Message:

Fix handling of Rambus memory modules.

Files:

• i2c-tools/trunk/eeprom/decode-dimms (modified) (3 diffs)

i2c-tools/trunk/eeprom/decode-dimms

@@ -1223 +1223 @@
 
 # Returns the (total, used) number of bytes in the EEPROM,
-# assuming it is an SPD EEPROM.
+# assuming it is a non-Rambus SPD EEPROM.
 sub spd_sizes($)
 {
@@ -1410 +1410 @@
          || $use_hexdump) {
                 my @bytes = readspd(128, $dimm_list[$i]);
-                my ($spd_size, $spd_used) = spd_sizes(\@bytes);
+                my $is_rambus = $bytes[0] < 4;          # Simple heuristic
                 my ($l, $chk_valid, $chk_spd, $chk_calc);
                 if ($bytes[2] < 9) {
@@ -1446 +1446 @@
                                 $chk_spd, $chk_calc));
 
-                # Simple heuristic to detect Rambus
-                my $is_rambus = $bytes[0] < 4;
                 my $temp;
                 if ($is_rambus) {
                         if ($bytes[0] == 1) { $temp = "0.7"; }
                         elsif ($bytes[0] == 2) { $temp = "1.0"; }
-                        elsif ($bytes[0] == 0 || $bytes[0] == 255) { $temp = "Invalid"; }
+                        elsif ($bytes[0] == 0) { $temp = "Invalid"; }
                         else { $temp = "Reserved"; }
                         printl "SPD Revision", $temp;
                 } else {
+                        my ($spd_size, $spd_used) = spd_sizes(\@bytes);
                         printl "# of bytes written to SDRAM EEPROM", $spd_used;
+                        printl "Total number of bytes in EEPROM", $spd_size;
                 }
-
-                $l = "Total number of bytes in EEPROM";
-                printl $l, $spd_size;
 
                 $l = "Fundamental Memory type";