Changeset 5558 for i2c-tools/trunk/eeprom/decode-dimms

Timestamp:

12/11/08 17:03:31 (3 years ago)

Author:

khali

Message:

Get rid of $l everywhere else.

Files:

• i2c-tools/trunk/eeprom/decode-dimms (modified) (15 diffs)

i2c-tools/trunk/eeprom/decode-dimms

@@ -710 +710 @@
 {
         my $bytes = shift;
-        my ($l, $temp);
+        my $temp;
 
 # SPD revision
@@ -721 +721 @@
         prints("Memory Characteristics");
 
-        $l = "Maximum module speed";
         $temp = ($bytes->[9] >> 4) + ($bytes->[9] & 0xf) * 0.1;
         my $ddrclk = 2 * (1000 / $temp);
@@ -730 +729 @@
         $pcclk = $pcclk - ($pcclk % 100);
         $ddrclk = int ($ddrclk);
-        printl($l, "${ddrclk}MHz (PC${pcclk})");
+        printl("Maximum module speed", "${ddrclk}MHz (PC${pcclk})");
 
 #size computation
@@ -889 +888 @@
 {
         my $bytes = shift;
-        my ($l, $temp);
+        my $temp;
         my $ctime;
 
@@ -901 +900 @@
         prints("Memory Characteristics");
 
-        $l = "Maximum module speed";
         $ctime = ddr2_sdram_ctime($bytes->[9]);
         my $ddrclk = 2 * (1000 / $ctime);
@@ -910 +908 @@
         $pcclk = $pcclk - ($pcclk % 100);
         $ddrclk = int ($ddrclk);
-        printl($l, "${ddrclk}MHz (PC2-${pcclk})");
+        printl("Maximum module speed", "${ddrclk}MHz (PC2-${pcclk})");
 
 #size computation
@@ -1034 +1032 @@
 {
         my $bytes = shift;
-        my $l;
         my $temp;
         my $ctime;
@@ -1048 +1045 @@
         prints("Memory Characteristics");
 
-        $l = "Fine time base";
         my $dividend = ($bytes->[9] >> 4) & 15;
         my $divisor  = $bytes->[9] & 15;
-        printl($l, sprintf("%.3f", $dividend / $divisor) . " ps");
-
-        $l = "Medium time base";
+        printl("Fine time base", sprintf("%.3f", $dividend / $divisor) . " ps");
+
         $dividend = $bytes->[10];
         $divisor  = $bytes->[11];
         my $mtb = $dividend / $divisor;
-        printl($l, tns3($mtb));
-
-        $l = "Maximum module speed";
+        printl("Medium time base", tns3($mtb));
+
         $ctime = $bytes->[12] * $mtb;
         my $ddrclk = 2 * (1000 / $ctime);
@@ -1065 +1059 @@
         my $pcclk = int ($ddrclk * $tbits / 8);
         $ddrclk = int ($ddrclk);
-        printl($l, "${ddrclk}MHz (PC3-${pcclk})");
+        printl("Maximum module speed", "${ddrclk}MHz (PC3-${pcclk})");
 
 # Size computation
@@ -1367 +1361 @@
 {
         my $bytes = shift;
-        my ($l, $temp);
+        my $temp;
 
         prints("Intel Specification");
 
-        $l = "Frequency";
         if ($bytes->[126] == 0x66) { $temp = "66MHz"; }
         elsif ($bytes->[126] == 100) { $temp = "100MHz or 133MHz"; }
         elsif ($bytes->[126] == 133) { $temp = "133MHz"; }
         else { $temp = "Undefined!"; }
-        printl($l, $temp);
-
-        $l = "Details for 100MHz Support";
+        printl("Frequency", $temp);
+
         $temp = "";
         if ($bytes->[127] & 1) { $temp .= "Intel Concurrent Auto-precharge\n"; }
@@ -1391 +1383 @@
         if (($bytes->[127] & 192) == 192) { $temp .= "Double-sided DIMM\n"; }
         elsif (($bytes->[127] & 192) != 0) { $temp .= "Single-sided DIMM\n"; }
-        printl($l, $temp);
+        printl("Details for 100MHz Support", $temp);
 }
 
@@ -1644 +1636 @@
                 my @bytes = readspd(0, 128, $dimm_list[$i]);
                 my $is_rambus = $bytes[0] < 4;          # Simple heuristic
-                my ($l, $chk_valid, $chk_spd, $chk_calc);
+                my ($label, $chk_valid, $chk_spd, $chk_calc);
                 if ($is_rambus || $bytes[2] < 9) {
-                        ($l, $chk_valid, $chk_spd, $chk_calc) =
+                        ($label, $chk_valid, $chk_spd, $chk_calc) =
                                 checksum(\@bytes);
                 } else {
-                        ($l, $chk_valid, $chk_spd, $chk_calc) =
+                        ($label, $chk_valid, $chk_spd, $chk_calc) =
                                 check_crc(\@bytes);
                 }
@@ -1674 +1666 @@
                 prints("SPD EEPROM Information");
 
-                printl($l, ($chk_valid ?
+                printl($label, ($chk_valid ?
                         sprintf("OK (%s)", $chk_calc) :
                         sprintf("Bad\n(found %s, calculated %s)",
@@ -1700 +1692 @@
                 }
 
-                $l = "Fundamental Memory type";
                 my $type = sprintf("Unknown (0x%02x)", $bytes[2]);
                 if ($is_rambus) {
@@ -1718 +1709 @@
                         }
                 }
-                printl($l, $type);
+                printl("Fundamental Memory type", $type);
 
 # Decode next 61 bytes (3-63, depend on memory type)