Changeset 5771

Timestamp:

09/17/09 17:59:38 (3 years ago)

Author:

khali

Message:

Add support for short writes with PEC.

Location:

i2c-tools/trunk

Files:

• CHANGES (modified) (1 diff)
• tools/i2cset.8 (modified) (2 diffs)
• tools/i2cset.c (modified) (3 diffs)

i2c-tools/trunk/CHANGES

@@ -15 +15 @@
   decode-xeon: Delete
   eepromer: Fix array initialization overrun
+  i2cset: Add support for short writes with PEC
   i2c-stub-from-dump: Use udev settle to speed up initialization
 

i2c-tools/trunk/tools/i2cset.8

@@ -12 +12 @@
 .I chip-address
 .I data-address
-.RI [ "value " [ "mode" ]]
+.RI [ value ]
+.RI [ mode ]
 .br
 .B i2cset
@@ -74 +75 @@
 mode without PEC. The \fIvalue\fR provided must be within range for the
 specified data type (0x00-0xFF for bytes, 0x0000-0xFFFF for words).
+Another possible mode is \fBc\fP, which doesn't write any value (so-called
+short write). You usually don't have to specify this mode, as it is the
+default when no value is provided, unless you also want to enable PEC.
 
 .SH WARNING

i2c-tools/trunk/tools/i2cset.c

@@ -3 +3 @@
     Copyright (C) 2001-2003  Frodo Looijaard <frodol@dds.nl>, and
                              Mark D. Studebaker <mdsxyz123@yahoo.com>
-    Copyright (C) 2004-2008  Jean Delvare <khali@linux-fr.org>
+    Copyright (C) 2004-2009  Jean Delvare <khali@linux-fr.org>
 
     This program is free software; you can redistribute it and/or modify
@@ -36 +36 @@
 {
         fprintf(stderr,
-                "Usage: i2cset [-f] [-y] [-m MASK] I2CBUS CHIP-ADDRESS DATA-ADDRESS [VALUE [MODE]]\n"
+                "Usage: i2cset [-f] [-y] [-m MASK] I2CBUS CHIP-ADDRESS DATA-ADDRESS [VALUE] [MODE]\n"
                 "  I2CBUS is an integer or an I2C bus name\n"
                 "  ADDRESS is an integer (0x03 - 0x77)\n"
                 "  MODE is one of:\n"
-                "    b (byte, default)\n"
-                "    w (word)\n"
+                "    c (byte, no value)\n"
+                "    b (byte data, default)\n"
+                "    w (word data)\n"
                 "    Append p for SMBus PEC\n");
         exit(1);
@@ -181 +182 @@
 
         if (argc > flags + 4) {
-                size = I2C_SMBUS_BYTE_DATA;
-                value = strtol(argv[flags+4], &end, 0);
-                if (*end || value < 0) {
-                        fprintf(stderr, "Error: Data value invalid!\n");
-                        help();
+                if (!strcmp(argv[flags+4], "c")
+                 || !strcmp(argv[flags+4], "cp")) {
+                        size = I2C_SMBUS_BYTE;
+                        value = -1;
+                        pec = argv[flags+4][1] == 'p';
+                } else {
+                        size = I2C_SMBUS_BYTE_DATA;
+                        value = strtol(argv[flags+4], &end, 0);
+                        if (*end || value < 0) {
+                                fprintf(stderr, "Error: Data value invalid!\n");
+                                help();
+                        }
                 }
         } else {