Changeset 582

Timestamp:

09/27/99 15:20:45 (9 years ago)

Author:

frodo

Message:

Some code cleanups

* Removed several superfluous (struct i2c_client *) casts (they were left

from the time we had separate structs for smbus and isa)

* Removed the internal lists of registered clients

They have not been used for quite some time now, took memory space,
and limited the maximum number of clients that could be registered.

Also removed two small Makefile errors - I am happy I caught them before
the next release!

Files:

• lm-sensors/trunk/TODO (modified) (1 diff)
• lm-sensors/trunk/kernel/chips/adm1021.c (modified) (7 diffs)
• lm-sensors/trunk/kernel/chips/adm9240.c (modified) (7 diffs)
• lm-sensors/trunk/kernel/chips/bt869.c (modified) (5 diffs)
• lm-sensors/trunk/kernel/chips/eeprom.c (modified) (6 diffs)
• lm-sensors/trunk/kernel/chips/gl520sm.c (modified) (7 diffs)
• lm-sensors/trunk/kernel/chips/icspll.c (modified) (5 diffs)
• lm-sensors/trunk/kernel/chips/lm75.c (modified) (7 diffs)
• lm-sensors/trunk/kernel/chips/lm78.c (modified) (10 diffs)
• lm-sensors/trunk/kernel/chips/lm80.c (modified) (6 diffs)
• lm-sensors/trunk/kernel/chips/ltc1710.c (modified) (6 diffs)
• lm-sensors/trunk/kernel/chips/matorb.c (modified) (7 diffs)
• lm-sensors/trunk/kernel/chips/maxilife.c (modified) (5 diffs)
• lm-sensors/trunk/kernel/chips/sis5595.c (modified) (5 diffs)
• lm-sensors/trunk/kernel/chips/thmc50.c (modified) (6 diffs)
• lm-sensors/trunk/kernel/chips/w83781d.c (modified) (7 diffs)
• lm-sensors/trunk/kernel/include/Module.mk (modified) (1 diff)
• lm-sensors/trunk/lib/Module.mk (modified) (2 diffs)

lm-sensors/trunk/TODO

@@ -11 +11 @@
-==============
-
-* All clients: We can remove the foo_list of registered clients. They are not 
-  used anymore.
-* Most clients: Some typecasts to `struct i2c_client' are completely 
-  unnecessary by now. Remove them.
-* LM78 detection: Tom Webster has proven that the reset bit in the 
-  id register can be one (strange!)

lm-sensors/trunk/kernel/chips/adm1021.c

@@ -183 +183 @@
-   allocation could also be used; the code needed for this would probably
-   take more memory than the datastructure takes now. */
-
-
+
-
-int adm1021_attach_adapter(struct i2c_adapter *adapter)
@@ -275 +274 @@
-  data->type = kind;
-
-
-
-
-
-
-
-
-
-
-
-
+
-  data->valid = 0;
-  init_MUTEX(&data->update_lock);
@@ -294 +283 @@
-
-  /* Register a new directory entry with module sensors */
-(struct i2c_client *) 
+
-                        type_name,
-                        data->type==adm1021?adm1021_dir_table_template:
@@ -304 +293 @@
-
-  /* Initialize the ADM1021 chip */
-(struct i2c_client *) 
+
-  return 0;
-
@@ -313 +302 @@
-  i2c_detach_client(new_client);
-ERROR3:
-  for (i = 0; i < MAX_ADM1021_NR; i++)
-    if (new_client == adm1021_list[i])
-      adm1021_list[i] = NULL;
-ERROR2:
-ERROR1:
-  kfree(new_client);
@@ -343 +328 @@
-{
-
-,i
+
-
-  sensors_deregister_entry(((struct adm1021_data *)(client->data))->sysctl_id);
@@ -351 +336 @@
-    return err;
-  }
-
-  for (i = 0; i < MAX_ADM1021_NR; i++)
-    if (client == adm1021_list[i])
-      break;
-  if ((i == MAX_ADM1021_NR)) {
-    printk("adm1021.o: Client to detach not found.\n");
-    return -ENOENT;
-  }
-  adm1021_list[i] = NULL;
-
-  kfree(client);

lm-sensors/trunk/kernel/chips/adm9240.c

@@ -287 +287 @@
-   allocation could also be used; the code needed for this would probably
-   take more memory than the datastructure takes now. */
-
-
+
-
-static struct i2c_driver adm9240_driver = {
@@ -428 +427 @@
-  data->type = kind;
-
-
-
-
-
-
-
-
-
-
-
-
+
-  data->valid = 0;
-  init_MUTEX(&data->update_lock);
@@ -447 +436 @@
-
-  /* Register a new directory entry with module sensors */
-(struct i2c_client *) 
+
-                                  type_name,
-                                  adm9240_dir_table_template)) < 0) {
@@ -456 +445 @@
-
-  /* Initialize the ADM9240 chip */
-(struct i2c_client *) 
+
-  return 0;
-
@@ -465 +454 @@
-  i2c_detach_client(new_client);
-ERROR3:
-  for (i = 0; i < MAX_ADM9240_NR; i++)
-    if (new_client == adm9240_list[i])
-      adm9240_list[i] = NULL;
-ERROR2:
-ERROR1:
-  kfree(new_client);
@@ -477 +462 @@
-int adm9240_detach_client(struct i2c_client *client)
-{
-,i
+
-
-  sensors_deregister_entry(((struct adm9240_data *)(client->data))->sysctl_id);
@@ -485 +470 @@
-    return err;
-  }
-
-  for (i = 0; i < MAX_ADM9240_NR; i++)
-    if (client == adm9240_list[i])
-      break;
-  if ((i == MAX_ADM9240_NR)) {
-    printk("adm9240.o: Client to detach not found.\n");
-    return -ENOENT;
-  }
-  adm9240_list[i] = NULL;
-
-  kfree(client);

lm-sensors/trunk/kernel/chips/bt869.c

@@ -152 +152 @@
-static int __initdata bt869_initialized = 0;
-
-
-
-
-
-
-
+
-
-int bt869_attach_adapter(struct i2c_adapter *adapter)
@@ -227 +222 @@
-  strcpy(new_client->name,client_name);
-
-
-
-
-
-
-
-
-
-
-
-
-
+
-  data->valid = 0;
-  init_MUTEX(&data->update_lock);
@@ -263 +247 @@
-  i2c_detach_client(new_client);
-ERROR3:
-  for (i = 0; i < MAX_bt869_NR; i++)
-    if (new_client == bt869_list[i])
-      bt869_list[i] = NULL;
-ERROR2:
-ERROR1:
-  kfree(new_client);
@@ -275 +255 @@
-int bt869_detach_client(struct i2c_client *client)
-{
-,i
+
-
-  sensors_deregister_entry(((struct bt869_data *)(client->data))->sysctl_id);
@@ -283 +263 @@
-    return err;
-  }
-
-  for (i = 0; i < MAX_bt869_NR; i++)
-    if (client == bt869_list[i])
-      break;
-  if ((i == MAX_bt869_NR)) {
-    printk("bt869.o: Client to detach not found.\n");
-    return -ENOENT;
-  }
-  bt869_list[i] = NULL;
-
-  kfree(client);

lm-sensors/trunk/kernel/chips/eeprom.c

@@ -149 +149 @@
-static int __initdata eeprom_initialized = 0;
-
-
-
-
-
-
+
-
-int eeprom_attach_adapter(struct i2c_adapter *adapter)
@@ -191 +187 @@
-  }
-
-((struct i2c_client *) new_client)
+new_client
-  new_client->addr = address;
-  new_client->data = data;
@@ -225 +221 @@
-  strcpy(new_client->name,client_name);
-
-
-
-
-
-
-
-
-
-
-
-
-
+
-  data->valid = 0;
-  init_MUTEX(&data->update_lock);
@@ -260 +245 @@
-  i2c_detach_client(new_client);
-ERROR3:
-  for (i = 0; i < MAX_EEPROM_NR; i++)
-    if (new_client == eeprom_list[i])
-      eeprom_list[i] = NULL;
-ERROR2:
-ERROR1:
-  kfree(new_client);
@@ -272 +253 @@
-int eeprom_detach_client(struct i2c_client *client)
-{
-,i
+
-
-  sensors_deregister_entry(((struct eeprom_data *)(client->data))->sysctl_id);
@@ -280 +261 @@
-    return err;
-  }
-
-  for (i = 0; i < MAX_EEPROM_NR; i++)
-    if (client == eeprom_list[i])
-      break;
-  if ((i == MAX_EEPROM_NR)) {
-    printk("eeprom.o: Client to detach not found.\n");
-    return -ENOENT;
-  }
-  eeprom_list[i] = NULL;
-
-  kfree(client);

lm-sensors/trunk/kernel/chips/gl520sm.c

@@ -281 +281 @@
-   allocation could also be used; the code needed for this would probably
-   take more memory than the datastructure takes now. */
-
-
+
-
-int gl520_attach_adapter(struct i2c_adapter *adapter)
@@ -353 +352 @@
-  data->type = kind;
-
-
-
-
-
-
-
-
-
-
-
-
+
-  data->valid = 0;
-  init_MUTEX(&data->update_lock);
@@ -372 +361 @@
-
-  /* Register a new directory entry with module sensors */
-(struct i2c_client *) 
+
-                                  type_name,
-                                  gl520_dir_table_template)) < 0) {
@@ -383 +372 @@
-  data->two_temps=1;
-  data->alarm_mask=0xff;
-(struct i2c_client *) 
+
-  return 0;
-
@@ -392 +381 @@
-  i2c_detach_client(new_client);
-ERROR3:
-  for (i = 0; i < MAX_GL520_NR; i++)
-    if (new_client == gl520_list[i])
-      gl520_list[i] = NULL;
-ERROR2:
-ERROR1:
-  kfree(new_client);
@@ -453 +438 @@
-int gl520_detach_client(struct i2c_client *client)
-{
-,i
+
-
-  sensors_deregister_entry(((struct gl520_data *)(client->data))->sysctl_id);
@@ -461 +446 @@
-    return err;
-  }
-
-  for (i = 0; i < MAX_GL520_NR; i++)
-    if (client == gl520_list[i])
-      break;
-  if ((i == MAX_GL520_NR)) {
-    printk("gl520sm.o: Client to detach not found.\n");
-    return -ENOENT;
-  }
-  gl520_list[i] = NULL;
-
-  kfree(client);

lm-sensors/trunk/kernel/chips/icspll.c

@@ -119 +119 @@
-static int __initdata icspll_initialized = 0;
-
-
-
-
-
-
-
-
+
-int icspll_attach_adapter(struct i2c_adapter *adapter)
-{
@@ -167 +161 @@
-    }
-
-    /* Find a place in our global list */
-    for (i = 0; i < MAX_ICSPLL_NR; i++)
-      if (! icspll_list[i])
-         break;
-    if (i == MAX_ICSPLL_NR) {
-      err = -ENOMEM;
-      printk("icspll.o: No empty slots left, recompile and heighten "
-             "MAX_ICSPLL_NR!\n");
-      goto ERROR1;
-    }
-    icspll_list[i] = new_client;
-    
-    /* Fill the new client structure with data */
-    data = (struct icspll_data *) (new_client + 1);
-    new_client->data = data;
-
+cspll_id++
-    new_client->addr = address;
-    new_client->adapter = adapter;
@@ -212 +194 @@
-    i2c_detach_client(new_client);
-ERROR2:
-    icspll_list[i] = NULL;
-ERROR1:
-    kfree(new_client);
@@ -222 +203 @@
-{
-  int err,i;
-  for (i = 0; i < MAX_ICSPLL_NR; i++)
-    if (client == icspll_list[i])
-      break;
-  if ((i == MAX_ICSPLL_NR)) {
-    printk("icspll.o: Client to detach not found.\n");
-    return -ENOENT;
-  }
-
-  sensors_deregister_entry(((struct icspll_data *)(client->data))->sysctl_id);
@@ -237 +211 @@
-  }
-
-  icspll_list[i] = NULL;
-  kfree(client);
-  return 0;

lm-sensors/trunk/kernel/chips/lm75.c

@@ -128 +128 @@
-static int __initdata lm75_initialized = 0;
-
-
-
-
-
-
-
+
-
-int lm75_attach_adapter(struct i2c_adapter *adapter)
@@ -171 +166 @@
-  }
-
-((struct i2c_client *) new_client)
+new_client
-  new_client->addr = address;
-  new_client->data = data;
@@ -205 +200 @@
-  strcpy(new_client->name,client_name);
-
-
-
-
-
-
-
-
-
-
-
-
-
+
-  data->valid = 0;
-  init_MUTEX(&data->update_lock);
@@ -232 +216 @@
-  data->sysctl_id = i;
-
-(struct i2c_client *) 
+
-  return 0;
-
@@ -241 +225 @@
-  i2c_detach_client(new_client);
-ERROR3:
-  for (i = 0; i < MAX_LM75_NR; i++)
-    if (new_client == lm75_list[i])
-      lm75_list[i] = NULL;
-ERROR2:
-ERROR1:
-  kfree(new_client);
@@ -253 +233 @@
-int lm75_detach_client(struct i2c_client *client)
-{
-,i
+
-
-  sensors_deregister_entry(((struct lm75_data *)(client->data))->sysctl_id);
@@ -261 +241 @@
-    return err;
-  }
-
-  for (i = 0; i < MAX_LM75_NR; i++)
-    if (client == lm75_list[i])
-      break;
-  if ((i == MAX_LM75_NR)) {
-    printk("lm75.o: Client to detach not found.\n");
-    return -ENOENT;
-  }
-  lm75_list[i] = NULL;
-
-  kfree(client);

lm-sensors/trunk/kernel/chips/lm78.c

@@ -239 +239 @@
-                         int *nrels_mag, long *results);
-
-/* I choose here for semi-static LM78 allocation. Complete dynamic
-   allocation could also be used; the code needed for this would probably
-   take more memory than the datastructure takes now. */
-#define MAX_LM78_NR 8
-static struct i2c_client *lm78_list[MAX_LM78_NR];
-
-static struct i2c_driver lm78_driver = {
-  /* name */            "LM78(-J) and LM79 sensor driver",
@@ -258 +252 @@
-/* Used by lm78_init/cleanup */
-static int __initdata lm78_initialized = 0;
+
+static int lm78_id = 0;
-
-/* The /proc/sys entries */
@@ -356 +352 @@
-     But it allows us to access lm78_{read,write}_value. */
-
-
-
+
-                              sizeof(struct lm78_data),
-                              GFP_KERNEL))) {
@@ -364 +359 @@
-  }
-
-((struct i2c_client *) new_client)
+new_client
-  if (is_isa) 
-    init_MUTEX(&data->lock);
@@ -422 +417 @@
-  data->type = kind;
-
-
-
-
-
-
-
-
-
-
-
-
+
-  data->valid = 0;
-  init_MUTEX(&data->update_lock);
@@ -441 +426 @@
-
-  /* Register a new directory entry with module sensors */
-(struct i2c_client *) 
+
-                                  type_name,
-                                  lm78_dir_table_template)) < 0) {
@@ -450 +435 @@
-
-  /* Initialize the LM78 chip */
-(struct i2c_client *) 
+
-  return 0;
-
@@ -459 +444 @@
-  i2c_detach_client(new_client);
-ERROR3:
-  for (i = 0; i < MAX_LM78_NR; i++)
-    if (new_client == lm78_list[i]) 
-      lm78_list[i] = NULL;
-ERROR2:
-  if (is_isa)
-    release_region(address,LM78_EXTENT);
@@ -473 +454 @@
-int lm78_detach_client(struct i2c_client *client)
-{
-,i
+
-
-  sensors_deregister_entry(((struct lm78_data *)(client->data))->sysctl_id);
@@ -481 +462 @@
-    return err;
-  }
-
-  for (i = 0; i < MAX_LM78_NR; i++)
-    if (client == lm78_list[i])
-      break;
-  if ((i == MAX_LM78_NR)) {
-    printk("lm78.o: Client to detach not found.\n");
-    return -ENOENT;
-  }
-  lm78_list[i] = NULL;
-
-  if i2c_is_isa_client(client)

lm-sensors/trunk/kernel/chips/lm80.c

@@ -228 +228 @@
-                         int *nrels_mag, long *results);
-
-
-
-
-
-
+
-
-static struct i2c_driver lm80_driver = {
@@ -317 +313 @@
-  }
-
-((struct i2c_client *) new_client)
+new_client
-  new_client->addr = address;
-  new_client->data = data;
@@ -351 +347 @@
-  strcpy(new_client->name,client_name);
-
-
-
-
-
-
-
-
-
-
-
-
-
+
-  data->valid = 0;
-  init_MUTEX(&data->update_lock);
@@ -386 +371 @@
-  i2c_detach_client(new_client);
-ERROR3:
-  for (i = 0; i < MAX_LM80_NR; i++)
-    if (new_client == lm80_list[i])
-      lm80_list[i] = NULL;
-ERROR2:
-ERROR1:
-  kfree(new_client);
@@ -398 +379 @@
-int lm80_detach_client(struct i2c_client *client)
-{
-,i
+
-
-  sensors_deregister_entry(((struct lm80_data *)(client->data))->sysctl_id);
@@ -406 +387 @@
-    return err;
-  }
-
-  for (i = 0; i < MAX_LM80_NR; i++)
-    if (client == lm80_list[i])
-      break;
-  if ((i == MAX_LM80_NR)) {
-    printk("lm80.o: Client to detach not found.\n");
-    return -ENOENT;
-  }
-  lm80_list[i] = NULL;
-
-  kfree(client);

lm-sensors/trunk/kernel/chips/ltc1710.c

@@ -142 +142 @@
-   allocation could also be used; the code needed for this would probably
-   take more memory than the datastructure takes now. */
-
-
+
-
-int ltc1710_attach_adapter(struct i2c_adapter *adapter)
@@ -181 +180 @@
-  }
-
-((struct i2c_client *) new_client)
+new_client
-  new_client->addr = address;
-  new_client->data = data;
@@ -207 +206 @@
-  strcpy(new_client->name,client_name);
-
-
-
-
-
-
-
-
-
-
-
-
-
+
-  data->valid = 0;
-  init_MUTEX(&data->update_lock);
@@ -242 +230 @@
-  i2c_detach_client(new_client);
-ERROR3:
-  for (i = 0; i < MAX_LTC1710_NR; i++)
-    if (new_client == ltc1710_list[i])
-      ltc1710_list[i] = NULL;
-ERROR2:
-ERROR1:
-  kfree(new_client);
@@ -255 +239 @@
-int ltc1710_detach_client(struct i2c_client *client)
-{
-,i
+
-
-  sensors_deregister_entry(((struct ltc1710_data *)(client->data))->sysctl_id);
@@ -263 +247 @@
-    return err;
-  }
-
-  for (i = 0; i < MAX_LTC1710_NR; i++)
-    if (client == ltc1710_list[i])
-      break;
-  if ((i == MAX_LTC1710_NR)) {
-    printk("ltc1710.o: Client to detach not found.\n");
-    return -ENOENT;
-  }
-  ltc1710_list[i] = NULL;
-
-  kfree(client);

lm-sensors/trunk/kernel/chips/matorb.c

@@ -113 +113 @@
-static int __initdata matorb_initialized = 0;
-
-
-
-
-
-
-
+
-
-int matorb_attach_adapter(struct i2c_adapter *adapter)
@@ -157 +152 @@
-  }
-
-((struct i2c_client *) new_client)
+new_client
-  new_client->addr = address;
-  new_client->data = data;
@@ -171 +166 @@
-  strcpy(new_client->name,client_name);
-
-
-
-
-
-
-
-
-
-
-
-
-
+
-  data->valid = 0;
-  init_MUTEX(&data->update_lock);
@@ -198 +182 @@
-  data->sysctl_id = i;
-
-(struct i2c_client *) 
+
-  return 0;
-
@@ -207 +191 @@
-  i2c_detach_client(new_client);
-ERROR3:
-  for (i = 0; i < MAX_MATORB_NR; i++)
-    if (new_client == matorb_list[i])
-      matorb_list[i] = NULL;
-ERROR2:
-  kfree(new_client);
-ERROR0:
@@ -218 +198 @@
-int matorb_detach_client(struct i2c_client *client)
-{
-,i
+
-
-  sensors_deregister_entry(((struct matorb_data *)(client->data))->sysctl_id);
@@ -226 +206 @@
-    return err;
-  }
-
-  for (i = 0; i < MAX_MATORB_NR; i++)
-    if (client == matorb_list[i])
-      break;
-  if ((i == MAX_MATORB_NR)) {
-    printk("matorb.o: Client to detach not found.\n");
-    return -ENOENT;
-  }
-  matorb_list[i] = NULL;
-
-  kfree(client);

lm-sensors/trunk/kernel/chips/maxilife.c

@@ -199 +199 @@
-
-
-
-
-
-
-
+
-
-/* The driver. I choose to use type i2c_driver, as at is identical to
@@ -376 +372 @@
-      i2c_detach_client(new_client);
-ERROR3:
-(struct i2c_client *) 
+
-ERROR2:
-      kfree(new_client);
@@ -385 +381 @@
-int maxi_detach_smbus(struct i2c_client *client)
-{
-
-
-
-
-
-
-
-
+
-
-   sensors_deregister_entry(((struct maxi_data *)(client->data))->sysctl_id);
@@ -409 +398 @@
-                    struct i2c_client *new_client)
-{
-   int i;
-   struct maxi_data *data;
-
-
-
-
-
-
-
-
-
-
-
-
-
+
-   new_client->adapter = adapter;
-   new_client->driver = &maxi_driver;
@@ -436 +413 @@
-void maxi_remove_client(struct i2c_client *client)
-{
-   int i;
-   for (i = 0; i < MAX_MAXI_NR; i++)
-      if (client == maxi_list[i]) 
-         maxi_list[i] = NULL;
-}
-

lm-sensors/trunk/kernel/chips/sis5595.c

@@ -218 +218 @@
-                         int *nrels_mag, long *results);
-
-
-
-
-
-
+
-
-/* The driver. I choose to use type i2c_driver, as at is identical to both
@@ -402 +398 @@
-  strcpy(new_client->name,client_name);
-
-
-
-
-
-
-
-
-
-
-
-
+
-  data->valid = 0;
-  init_MUTEX(&data->update_lock);
@@ -439 +425 @@
-  i2c_detach_client(new_client);
-ERROR3:
-  for (i = 0; i < MAX_SIS5595_NR; i++)
-    if (new_client == sis5595_list[i])
-      sis5595_list[i] = NULL;
-ERROR2:
-  release_region(address,SIS5595_EXTENT);
-ERROR1:
@@ -452 +434 @@
-int sis5595_detach_client(struct i2c_client *client)
-{
-,i
+
-
-  sensors_deregister_entry(((struct sis5595_data *)(client->data))->sysctl_id);
@@ -460 +442 @@
-    return err;
-  }
-
-  for (i = 0; i < MAX_SIS5595_NR; i++)
-    if (client == sis5595_list[i])
-      break;
-  if ((i == MAX_SIS5595_NR)) {
-    printk("sis5595.o: Client to detach not found.\n");
-    return -ENOENT;
-  }
-  sis5595_list[i] = NULL;
-
-  release_region(client->addr,SIS5595_EXTENT);

lm-sensors/trunk/kernel/chips/thmc50.c

@@ -170 +170 @@
-static int __initdata thmc50_initialized = 0;
-
-
-
-
-
-
-
+
-
-int thmc50_attach_adapter(struct i2c_adapter *adapter)
@@ -249 +244 @@
-  strcpy(new_client->name,client_name);
-
-
-
-
-
-
-
-
-
-
-
-
-
+
-  data->valid = 0;
-  init_MUTEX(&data->update_lock);
@@ -276 +260 @@
-  data->sysctl_id = i;
-
-(struct i2c_client *) 
+
-  return 0;
-
@@ -285 +269 @@
-  i2c_detach_client(new_client);
-ERROR3:
-  for (i = 0; i < MAX_THMC50_NR; i++)
-    if (new_client == thmc50_list[i])
-      thmc50_list[i] = NULL;
-ERROR2:
-ERROR1:
-  kfree(new_client);
@@ -297 +277 @@
-int thmc50_detach_client(struct i2c_client *client)
-{
-,i
+
-
-  sensors_deregister_entry(((struct thmc50_data *)(client->data))->sysctl_id);
@@ -305 +285 @@
-    return err;
-  }
-
-  for (i = 0; i < MAX_THMC50_NR; i++)
-    if (client == thmc50_list[i])
-      break;
-  if ((i == MAX_THMC50_NR)) {
-    printk("thmc50.o: Client to detach not found.\n");
-    return -ENOENT;
-  }
-  thmc50_list[i] = NULL;
-
-  kfree(client);

lm-sensors/trunk/kernel/chips/w83781d.c

@@ -405 +405 @@
-#endif
-
-
-
-
-
-
+
-
-static struct i2c_driver w83781d_driver = {
@@ -695 +691 @@
-  }
-
-((struct i2c_client *) new_client)
+new_client
-  new_client->addr = address;
-  init_MUTEX(&data->lock);
@@ -774 +770 @@
-  data->type = kind;
-
-
-
-
-
-