Ticket #2150 (closed enhancement: fixed)

Opened 8 years ago

Last modified 8 years ago

[PATCH] vt1211 support for sensord

Reported by: ticket Owned by: khali
Priority: minor Milestone:
Component: interface Version: 2.10.1
Keywords: vt1211 sensord Cc: juergh@…

Description

A straightfoward patching adding vt1211 support to sensord.

Note that I had to disable the temp3 in the feature structure since sensord reported it incorrectly on my system (VIA EPIA ML8000). I did not test other temperature inputs, they may have the same problem.

Attachments

sensord-vt1211.diff Download (3.0 KB) - added by ticket 8 years ago.

Change History

Changed 8 years ago by ticket

Changed 8 years ago by ticket

"I had to disable the temp3" was meant to read "I had to disable the temp3 ALARM"

:)

Changed 8 years ago by khali

  • cc juergh@… added
  • keywords vt1211 sensord added
  • status changed from new to assigned
  • owner changed from somebody to khali

Thanks for the patch, I've applied it to the SVN repository, with fixes to fan2_div and vid. You would have received credit for it if only I knew your name...

I've restored the temp3 alarm, we can't disable that feature just on the basis that it doesn't work for you. If there is a bug with the temp3 alarm in libsensors or the vt1211 driver, let's fix it where it is. But you'd need to give much more details than "it is reported incorrectly". What are the symptoms? Which version of the driver do you use exactly? We had to make changes to the vt1211 support in libsensors when the driver was ported to Linux 2.6, so older versions of the driver are no longer compatible, in particular some temperature channels were reordered, this could be related to your problem.

Changed 8 years ago by ticket

Nice to see the patch being integrated so fast. Well, I guess I'll sign next time, although the anonimity makes the contribution much more heroic.

Seriously though, sensord reports the alarm as being raised although the sensors program does not and the temperature is well below the hysteresis and the limit. I'm using the 2.6.18.2 driver from this page:  http://hem.bredband.net/ekmlar/vt1211.html which looks quite different to the one in the lm-sensors trunk. As I said, it works pretty well with the 'sensors' program (although the VID reading is wrong). Should I be using the 2.10.1 / trunk version instead ? Anyway, I'm much too lazy to try to debug the whole thing, especially with my knowledge of lm-sensors/driver/hardware stuff.

Thanks for your time !

Changed 8 years ago by khali

  • status changed from assigned to closed
  • resolution set to fixed

The driver you are using is not supported by us. The vt1211 driver we support is the one which was merged into Linux 2.6.19, which received several significant changes from Lars Ekman's version. In particular temperature inputs were reordered. If you are using lm_sensors 2.10.1 with Lars' driver, I am not surprised you have problems, as 2.10.1 was updated to work with the vt1211 driver in Linux 2.6.19.

Note: See TracTickets for help on using tickets.