Ticket #2295 (closed defect: fixed)

Opened 11 months ago

Last modified 11 months ago

lm93 VID2 detection error "ERROR: Can't get VID data! (0x0fa2)"

Reported by: ticket Assigned to: khali
Priority: critical Milestone: 2.10.6
Component: libsensors Version: 2.10.5
Keywords: lm93 vid Cc: jacoby.hickerson@live.com

Description

The chips.c file was modified to remove the lm93 VID macro, however, the second VID value is not being detected because the SENSORS_LM93_VID1 constant was repeated for vid2: 

    { { SENSORS_LM93_VID1, "vid1", NOMAP, NOMAP, R },
                          LM93_SYSCTL_VID1, VALUE(1), 3, "cpu0_vid", 3, "vid1" },
    { { SENSORS_LM93_VID1, "vid2", NOMAP, NOMAP, R },
                          LM93_SYSCTL_VID2, VALUE(1), 3, "cpu1_vid", 3, "vid2" },

the fix should be... 

    { { SENSORS_LM93_VID1, "vid1", NOMAP, NOMAP, R },
                          LM93_SYSCTL_VID1, VALUE(1), 3, "cpu0_vid", 3, "vid1" },
    { { SENSORS_LM93_VID2, "vid2", NOMAP, NOMAP, R },
                          LM93_SYSCTL_VID2, VALUE(1), 3, "cpu1_vid", 3, "vid2" },

Change History

01/10/08 08:59:15 changed by khali

  • keywords changed from libsensors lm93 vid to lm93 vid.
  • owner changed from somebody to khali.
  • status changed from new to assigned.

Good catch, thanks for reporting.

01/10/08 09:13:05 changed by khali

  • status changed from assigned to closed.
  • resolution set to fixed.

Fixed in r5105.