Ticket #2365 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Circular dependencies crash libsensors

Reported by: khali Owned by: khali
Priority: minor Milestone: 3.1.0
Component: libsensors Version: 3.0.3
Keywords: Cc:

Description

The following configuration file causes libsensors to die with a segmentation fault:

chip "*-*"

   compute in0 @+in1_input, @-in1_input
   compute in1 @+in0_input, @-in0_input

This configuration file is clearly not correct, but libsensors should still not crash on it.

Change History

Changed 3 years ago by khali

  • owner changed from somebody to khali
  • status changed from new to assigned

Changed 3 years ago by khali

  • status changed from assigned to closed
  • resolution set to fixed

Fixed in r5582. I simply limited recursion depth. It's much easier (and faster) than cleanly detecting cycles, and should be equally efficient in practice.

Note: See TracTickets for help on using tickets.